Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle callUser links in Talk without page reload #11879

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: handle callUser links in Talk without page reload #11879

merged 1 commit into from
Apr 10, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 20, 2024 •
edited by Antreesy

☑️ Resolves

  • Allows to handle /apps/spreed?callUser=... without page reloading, for example, for:
    • Links in the chat, like with links to a conversation
    • Contacts menu on Talk Desktop (not in the Web, requires feat/in-app-talk-links-support branch for desktop build)
      image

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

During loading

image

In case of error - redirect to not found

image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme self-assigned this Mar 20, 2024
@ShGKme ShGKme force-pushed the feat/callUser-links-via-router branch from dcdf71d to 2fefec8 Compare April 10, 2024 09:44
@ShGKme
feat: handle callUser links on page without reload
47a320e 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the feat/callUser-links-via-router branch from 2fefec8 to 47a320e Compare April 10, 2024 10:07
@ShGKme ShGKme marked this pull request as ready for review April 10, 2024 10:08
Antreesy
Antreesy approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with web and Desktop client

@ShGKme ShGKme changed the title feat: handle callUser links on page without reload feat: handle callUser links in Talk without page reload Apr 10, 2024
@ShGKme ShGKme merged commit bd62d5b into main Apr 10, 2024
46 of 47 checks passed
@ShGKme ShGKme deleted the feat/callUser-links-via-router branch April 10, 2024 14:52
@ShGKme
Copy link
Contributor Author

ShGKme commented Apr 10, 2024

/backport to stable29

@backportbot backportbot bot mentioned this pull request Apr 10, 2024
Merged
This was referenced Apr 11, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
💙 Next Major (30)
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ShGKme @nickvergessen @DorraJaouad @Antreesy