Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⛔ feat(ban): Contract for banning attendees and IP/ranges #12259

Merged
merged 1 commit into from
May 8, 2024
Merged

⛔ feat(ban): Contract for banning attendees and IP/ranges #12259

merged 1 commit into from
May 8, 2024
+1,235 −6

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 3, 2024 •
edited
Loading

🛠️ API Checklist

🚧 Tasks

  • Allows to send a ban
  • Get a list of bans
  • Remove a ban
  • Experience a ban
    • If conversation is named ban user, the user with id banned is banned (can not join)
    • If conversation is named ban guest, all guests are banned (can not join)
  • forgot to do: Feature capability: ban-v1

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen self-assigned this May 3, 2024
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone May 3, 2024
@nickvergessen nickvergessen force-pushed the feat/noid/contract-ban branch 2 times, most recently from 8e190bb to ae9e0af Compare May 3, 2024 21:34
This was referenced May 7, 2024
Open
Open
Open
Open
Open
@nickvergessen nickvergessen changed the title feat(ban): Contract for banning attendees and IP/ranges ⛔ feat(ban): Contract for banning attendees and IP/ranges May 7, 2024
Antreesy
Antreesy approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fine, but I'm struggling now to imagine how it would be used later on (from moderator perspective)

lib/Controller/BanController.php Show resolved Hide resolved
lib/Controller/BanController.php Show resolved Hide resolved
@nickvergessen
feat(ban): Contract for banning attendees and IP/ranges
3cda633 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit eb500f5 into main May 8, 2024
64 checks passed
@nickvergessen nickvergessen deleted the feat/noid/contract-ban branch May 8, 2024 10:10
@mahibi mahibi requested a review from rapterjet2004 May 8, 2024 11:39
@nickvergessen nickvergessen mentioned this pull request Jun 24, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥
Projects
💬 Talk team
Status: ☑️ Done
Milestone
💙 Next Major (30)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickvergessen @Antreesy