Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification levels #1230

Merged
merged 9 commits into from Oct 9, 2018
Merged

Notification levels #1230

merged 9 commits into from Oct 9, 2018

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 1, 2018

Fix #1099

  • Add DB + model change
  • Add endpoint
  • Respect the setting
  • Add UI to change the setting

@nickvergessen nickvergessen added 2. developing backport-request enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Oct 1, 2018
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Oct 1, 2018
@fsxadmin
Copy link

fsxadmin commented Oct 2, 2018

oooo we are so excited! please make this happen for the major release, thank you! After this, we will consider the enterprise licensing

@nickvergessen
Copy link
Member Author

@jancborchardt currently we go for 3 options:

  • Never notify
  • On mention
  • Always

where/how should users be able to set this? In the menu of the conversation list? Or the right sidebar top section?

Additionally, should we show something similar to the grey mute icon Whatapp and others are showing when a conversation is set to "never"?
screenshot_20181005-163735

@fsxadmin
Copy link

fsxadmin commented Oct 5, 2018

for sure in the ... shown here:
image

@fsxadmin
Copy link

fsxadmin commented Oct 5, 2018

Thanks for your diligence @nickvergessen !!

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 8, 2018

Ready for review. I also think that the dropdown menu is the right place, since it also handles the favorite state, so it looks like the following screenshot for now:

bildschirmfoto von 2018-10-08 15-10-53

From IRC:

@MorrisJobke : nickvergessen: looks nice 👍

We can also go for other icons (I think they are fine, although a crossed-through speaker would be better for never) and/or a new layout (putting the icons in one row with hover title, or whatever)

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/1099/notification-levels branch from fca7851 to 64e2625 Compare October 8, 2018 13:26
Signed-off-by: Joas Schilling <coding@schilljs.com>
@Ivansss
Copy link
Member

Ivansss commented Oct 8, 2018

Notification's text should change when someone writes in a group/public room.
At the moment you receive: "{user} sent you a private message"
It should be something like: "{user} wrote a message in {room name}"

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Notification's text should change when someone writes in a group/public room.
At the moment you receive: "{user} sent you a private message"
It should be something like: "{user} wrote a message in {room name}"

done

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit a5a0984 into master Oct 9, 2018
@nickvergessen nickvergessen deleted the feature/1099/notification-levels branch October 9, 2018 12:46
@jancborchardt
Copy link
Member

Looks great @nickvergessen! :) Also yes for the mute-icon like in Signal and WhatsApp.

The default notification setting for every channel should be on @-mention initially.

@mario
Copy link
Contributor

mario commented Oct 9, 2018

@jancborchardt people waited forever to get ALWAYS notifications in 1-to-1 conversations. Why take it away from them?

@nickvergessen
Copy link
Member Author

Default remains the current behaviour:

  • One2one: Always
  • Others: Mention

@mario
Copy link
Contributor

mario commented Oct 9, 2018 via email

@jancborchardt
Copy link
Member

Totally missed this – just for the record, when I said "for every channel" I meant "for every group channel". So the defaults @nickvergessen mentioned are 👍

@errotu
Copy link

errotu commented Aug 13, 2019

First of all, thanks a lot to everyone here for your great work!

We are introducing Talk at the moment in our organization and there have been several complaints with regard to the notification level (it actually took me a while to figure out the "notification if mentioned"-level, since this is not the default option I know from other messengers):
Would it be possible to introduce a feature to change the default behaviour server-wide or in ones own personal settings? We are working with many groups and it's quite incommodious to change it every single time for every group again.

Once again, thanks a lot for all your work!

@jancborchardt
Copy link
Member

@errotu could you open a new issue with your request? :) Listing comparisons with how other messengers are doing it are very welcome too.

@errotu
Copy link

errotu commented Aug 14, 2019

@jancborchardt Thanks for the quick reply! I have now opened #2085.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for notification levels
6 participants