New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Correctly cast the incall flag to integer #1291

Merged
merged 2 commits into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@nickvergessen
Member

nickvergessen commented Nov 12, 2018

Backport #1231 + #1233
Fix #1283

nickvergessen added some commits Oct 1, 2018

Correctly cast the in_call flag to integer
Signed-off-by: Joas Schilling <coding@schilljs.com>
Fix bool logic for inCall flag
Signed-off-by: Joas Schilling <coding@schilljs.com>
@fancycode

lgtm

@nickvergessen nickvergessen merged commit 452a672 into stable14 Nov 12, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@nickvergessen nickvergessen deleted the backport/1231/correctly-cast-the-incall-flag-to-integer branch Nov 12, 2018

nickvergessen added a commit that referenced this pull request Nov 15, 2018

Prepare 4.0.1
**Added**
- Add an option to test the TURN configuration in the admin settings
  [#1294](#1294)

**Changed**
- Improve the notifications when a share password is requested
  [#1296](#1296)
- Do not show an error when a file is shared a second time into a conversation
  [#1295](#1295)

**Fixed**
- Custom Signaling, STUN and TURN configurations are not loaded for the user requesting the password for a share
  [#1297](#1297)
- Fix position of the contacts menu when clicking on the avatar of a chat author
  [#1293](#1293)
- Avatars in messages/mentions by guests show the guest avatar instead of the user
  [#1292](#1292)
- Information about user state in a call is bugged
  [#1291](#1291)
- Wrong conversation name of password requests in the details sidebar
  [#1290](#1290)
- Fix rendering, reloading and interaction with the participant list
  [#1222](#1222)
  [#1289](#1289)

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen added a commit that referenced this pull request Dec 6, 2018

Prepare 4.0.1
**Added**
- Add an option to test the TURN configuration in the admin settings
  [#1294](#1294)

**Changed**
- Improve the notifications when a share password is requested
  [#1296](#1296)
- Do not show an error when a file is shared a second time into a conversation
  [#1295](#1295)

**Fixed**
- Custom Signaling, STUN and TURN configurations are not loaded for the user requesting the password for a share
  [#1297](#1297)
- Fix position of the contacts menu when clicking on the avatar of a chat author
  [#1293](#1293)
- Avatars in messages/mentions by guests show the guest avatar instead of the user
  [#1292](#1292)
- Information about user state in a call is bugged
  [#1291](#1291)
- Wrong conversation name of password requests in the details sidebar
  [#1290](#1290)
- Fix rendering, reloading and interaction with the participant list
  [#1222](#1222)
  [#1289](#1289)

Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment