[stable14] Correctly cast the incall flag to integer #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
bug
feature: api 🛠️
nickvergessen
deleted the
backport/1231/correctly-cast-the-incall-flag-to-integer
branch
nickvergessen
added a commit
that referenced
this pull request
Nov 15, 2018
**Added** - Add an option to test the TURN configuration in the admin settings [#1294](#1294) **Changed** - Improve the notifications when a share password is requested [#1296](#1296) - Do not show an error when a file is shared a second time into a conversation [#1295](#1295) **Fixed** - Custom Signaling, STUN and TURN configurations are not loaded for the user requesting the password for a share [#1297](#1297) - Fix position of the contacts menu when clicking on the avatar of a chat author [#1293](#1293) - Avatars in messages/mentions by guests show the guest avatar instead of the user [#1292](#1292) - Information about user state in a call is bugged [#1291](#1291) - Wrong conversation name of password requests in the details sidebar [#1290](#1290) - Fix rendering, reloading and interaction with the participant list [#1222](#1222) [#1289](#1289) Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added a commit
that referenced
this pull request
Dec 6, 2018
**Added** - Add an option to test the TURN configuration in the admin settings [#1294](#1294) **Changed** - Improve the notifications when a share password is requested [#1296](#1296) - Do not show an error when a file is shared a second time into a conversation [#1295](#1295) **Fixed** - Custom Signaling, STUN and TURN configurations are not loaded for the user requesting the password for a share [#1297](#1297) - Fix position of the contacts menu when clicking on the avatar of a chat author [#1293](#1293) - Avatars in messages/mentions by guests show the guest avatar instead of the user [#1292](#1292) - Information about user state in a call is bugged [#1291](#1291) - Wrong conversation name of password requests in the details sidebar [#1290](#1290) - Fix rendering, reloading and interaction with the participant list [#1222](#1222) [#1289](#1289) Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #1231 + #1233
Fix #1283