Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the contacts menu in the participant list #1822

Merged
merged 5 commits into from Jul 12, 2019

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 15, 2019

@skjnldsv layout is broken becuase sidebar navigation and contacts menu collide, can you help solve this?

Fix #1795

Contacts menu in chat mention

Bildschirmfoto von 2019-05-15 14-22-57

Contacts menu in participant list

Bildschirmfoto von 2019-05-15 14-22-52

Signed-off-by: Joas Schilling <coding@schilljs.com>
@marcoambrosini
Copy link
Member

@nickvergessen could you describe a bit more how to reproduce the issue?

@nickvergessen
Copy link
Member Author

So without this PR when you click on the user avatar in the right sidebar nothing happens.
With this PR the pop up is shown, but the icons of the options seem to be broken a lot.

@marcoambrosini
Copy link
Member

I just fixed the overflow which was hidden on the popup container and a scrollbar appeared, but the icons seem fine to me, how should they look?
Screenshot from 2019-07-02 14-34-46

@marcoambrosini
Copy link
Member

Ok, I just saw what you mean.. I fixed another bug then :)
I'll check the avatars now

marcoambrosini and others added 3 commits July 2, 2019 16:09
…ebar

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@marcoambrosini
Copy link
Member

Great Joas, one last thing: do you also see the left part of the menu hidden?
Screenshot from 2019-07-02 17-50-02

@nickvergessen
Copy link
Member Author

Yeah, it's from .popovermenu.contactsmenu-popover { which adds margin: 0;
If I set this to 4px the popup is out of position but with border.

maybe @skjnldsv can have a look

@skjnldsv
Copy link
Member

skjnldsv commented Jul 3, 2019

No idea about this one, I did not create it. @juliushaertl ?
We're now all using the dedicated vue component 🙈

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 12, 2019

Fixed the missing border. Good to merge now

Bildschirmfoto von 2019-07-12 14-46-10

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nickvergessen nickvergessen merged commit c6fee1e into master Jul 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/1795/contacts-menu-in-participant-list branch July 12, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to create private 1-1 conversation from participant list
3 participants