1st try default group notification setting

[jakobroehrl]

Fix #2069
Fix #2085

@nickvergessen
Thanks for your great help 👍

What do you think about the code?
Now the added users have no preselection here:

[nickvergessen]

I pushed some commits to clean up the code a bit. Hope this is okay for you.

So now we are missing the dirty parts in spreed/lib/Chat/Notifier.php. Do you want to take care of them as well, or shall I take over. I think it gets a bit/lot more complicated in there.

[jakobroehrl]

@nickvergessen
Thank you, tested it.
If I use "All messages" in the admin settings and create a group the chat notifications of the users are:

This is stil a problem, isn't it?

I look over the Notifier.php yesterday, it was a bit confusing. So if you are willing to explain a little bit more I could do it maybe.

Or there are other small Issues I can help? #774 #1127 #2800 #2226 would be interessting to me, is there an easy one?

[nickvergessen]

I look over the Notifier.php yesterday, it was a bit confusing. So if you are willing to explain a little bit more I could do it maybe.

Let me try this later.

Or there are other small Issues I can help? #774 #1127 #2800 #2226 would be interessting to me, is there an easy one?

While they sound neat, I think none of them qualifies for "easy". Especially since they should then also work in our mobile apps (apart from the task creation I guess). You could otherwise try to look through the issues of https://github.com/nextcloud/spreed/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22 We try to flag issues with that "good first issue" label where we think it's easy to get started.

Btw, feel free to join our "Talk development" chat at https://cloud.nextcloud.com/call/c7fz9qpr
Might be easier to answer questions more quickly

[nickvergessen]

If I use "All messages" in the admin settings and create a group the chat notifications of the users are

Fixed now

[jakobroehrl]

Fixed now

Sorry, it's not working for me. No matter what I choose in the admin settings, the chat notification for the users is always "@-mention"

[nickvergessen]

Well most likely because you selected the value once?
Try creating a new conversation and don't touch the setting in the … menu

[nickvergessen]

I fixed the backend. For me the setting is now working as intended and also shows correct in the UI (remember to make build-js the new javascript)

[jakobroehrl]

I fixed the backend. For me the setting is now working as intended and also shows correct in the UI (remember to make build-js the new javascript)

It's not working, sorry.
The after a change in the admin config, it looks wired:

When I relaod the page it's ok again:

And after creating a new group, it's still the wrong notifiction:

[marcoambrosini]

@jakobroehrl it works for me as well.
Are you using 2 separate tabs for talk and settings? I've managed to reproduce the behavior you describe that way.

[jakobroehrl]

@jakobroehrl it works for me as well.
Are you using 2 separate tabs for talk and settings? I've managed to reproduce the behavior you describe that way.

No, I do not, this is strange...

[nickvergessen]

Let's merge this for now and in case we have troubles going forward, we at least know what caused it

[nickvergessen]

Unit tests are failing.... fixing

[jakobroehrl]

Hi, thanks for your work.
How could I support you guys?
The notifications are still open, I don't know if I can do this.

[nickvergessen]

• Integration tests seem to 💥

[nickvergessen]

/backport to stable18

[backportbot-nextcloud]

backport to stable18 in #2903

[nickvergessen]

Thanks again for the start on this @jakobroehrl Feel free to pick any other "good first issue" if you want to continue

[jakobroehrl]

@nickvergessen Thanks for the quick release, it's working! 👍