New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ping call more error tolerant #320
Conversation
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
js/rooms.js
Outdated
}).fail(function(xhr, status, error) { | ||
// If there is an error when pinging, retry for 3 times. | ||
if (xhr.status !== 404 && pingFails < 3) { | ||
pingFails ++; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove space
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
============================================
+ Coverage 15.46% 15.62% +0.15%
Complexity 274 274
============================================
Files 18 18
Lines 1293 1293
============================================
+ Hits 200 202 +2
+ Misses 1093 1091 -2
Continue to review full report at Codecov.
|
js/rooms.js
Outdated
).fail(function() { | ||
).done(function() { | ||
pingFails = 0; | ||
}).fail(function(xhr, status, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused error
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
AppNavigationNew: fix type of buttonClass
No description provided.