Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make leave-call button red #3348

Merged
merged 1 commit into from Apr 20, 2020

Conversation

marcoambrosini
Copy link
Member

Peek 2020-04-18 14-41

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@nickvergessen
Copy link
Member

This will make the dark mode icon color issue even more difficult to solve 😬

@marcoambrosini
Copy link
Member Author

This will make the dark mode icon color issue even more difficult to solve

Worth the hassle imo: every "leave call" button in the world is red, so here we have the opportunity to make our UI clearer by sticking to the pattern

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised

@nickvergessen nickvergessen merged commit 7506bd2 into master Apr 20, 2020
@nickvergessen nickvergessen deleted the feature/noid/improve-callbutton-style branch April 20, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants