Fix logout failure if active session was removed from room #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Jul 1, 2020
|
Time to fixup |
nickvergessen
added
4. to release
feature: api 🛠️
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
If the user tries to immediately log out after being removed from a conversation in which she was active an exception could be thrown during the logout cleanup if no conversation is found for the session. If the exception is not caught then the logout will fail. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
fix-logout-failure-if-active-session-was-removed-from-room
branch
from
b3a6096
to
c8e8b7b
Compare
nickvergessen
deleted the
fix-logout-failure-if-active-session-was-removed-from-room
branch
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
|
The backport to stable17 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
Result with this pull request
The user is logged out.
Result without this pull request
An error occurs during the log out and the user is not logged out.