-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New message form facelift #4584
Conversation
@nickvergessen pointed out that there are too many shades of gray. I could remove the circle around the X button when it's not hovered so it's bee one less shade. What do you think? |
As briefly mentioned in our call, I would say if we change it, then I’d expect the input field to be grey, not the block around it. Because the current style (please always do before / after comparison screenshots :) actually looks very light and nice like @jenniferpiperek designed it, and changing to having a whole grey block down there is a bit massive. (As @nickvergessen also pointed out.) (And then again, input fields are usually not grey but always white with a border around it, so I see a high risk in breaking that convention. On first glance it would look like a disabled button or disabled input field more than a regular input field.) |
8c01c18
to
4df6877
Compare
Looks better, and then we don't need the additional horizontal line anymore? Could either be done with a fade to white, or only showing the line when not scrolled all the way to the bottom (that's what e.g. Signal does). |
Looking great now! :) The commits seem messed up though, as e.g. also the button-looking date dividers which we don’t want are in here? |
Yep needs some cleanup. |
bafa13f
to
d47ff3e
Compare
97a2824
to
cf4d006
Compare
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
cf4d006
to
2becc41
Compare
class="new-message-form__button submit" | ||
@click.prevent="handleSubmit"> | ||
<Send | ||
:size="20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no title, so its always "Send" instead of being translated
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: Marco Ambrosini marcoambrosini@pm.me