Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to resend temporary messages if the failure was not permissions #4975

Merged
merged 2 commits into from Jan 22, 2021

Conversation

nickvergessen
Copy link
Member

Fix #2454

Peek 2021-01-19 21-03

Also supports parallel errors much better now. If previous you would send each line as a message:

Lorem
ipsum
dolor
sit
amet

And they all failed e.g. due to network, you got "amet" recovered into the input while the rest is gone. Now you have to click on them one by one, but therefore can also recover them all.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

For testing I patched:

diff --git a/lib/Controller/ChatController.php b/lib/Controller/ChatController.php
index 9aecf0fbe..539d14188 100644
--- a/lib/Controller/ChatController.php
+++ b/lib/Controller/ChatController.php
@@ -165,6 +165,7 @@ class ChatController extends AEnvironmentAwareController {
         *         found".
         */
        public function sendMessage(string $message, string $actorDisplayName = '', string $referenceId = '', int $replyTo = 0): DataResponse {
+               sleep(7);
                if ($this->userId === null) {
                        $actorType = Attendee::ACTOR_GUESTS;
                        $sessionId = $this->session->getSessionForRoom($this->room->getToken());

and restarted apache in the meantime

@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 19, 2021

  • @ma12-co can you turn the button in the retry-possible case into a correct button with 44px shade, etc.

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini force-pushed the bugfix/2454/handle-temporary-messages-better branch from 2ee6eb4 to d07941a Compare January 22, 2021 11:47
@marcoambrosini
Copy link
Member

marcoambrosini commented Jan 22, 2021

I created a file in which to start to apply the new buttons styles with the goal to upstream it once it's ready

@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 22, 2021

Thanks, button works ✅ (can't approve as it's my PR)

@marcoambrosini marcoambrosini merged commit c209b4a into master Jan 22, 2021
@marcoambrosini marcoambrosini deleted the bugfix/2454/handle-temporary-messages-better branch January 22, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling for temporary messages
2 participants