Fix scrolling chat when in the background #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before scrollTo() was used, but this does not work when the window is not visible. So now when the chat is in the background we scroll only half a line and stop following. The user will see that something happened and have the anchor to jump to the bottom. Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
bug
feature: chat 💬
nickvergessen
commented
Jan 20, 2021
| top: this.scroller.scrollHeight, | ||
| behavior: 'smooth', | ||
| }) | ||
| this.setChatScrolledToBottom(true) |
There was a problem hiding this comment.
I think this is actually what the biggest problem was. It removed the scroll-to-bottom button, although it wasn't scrolled to the bottom
marcoambrosini
approved these changes
Jan 20, 2021
marcoambrosini
deleted the
bugfix/noid/fix-scrolling-chat-when-in-background
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before scrollTo() was used, but this does not work when the window is not visible.
So now when the chat is in the background we scroll only half a line and stop following.
The user will see that something happened and have the anchor to jump to the bottom.
cc @ma12-co @jancborchardt The main question is if the "scroll only half" behaviour is actually wanted, or if we should just scrolldown fully (as it was attempted to, but didn't do because scrollTo() only works on visible windows)