Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the wav encoder in the entry points instead of in the audiorecorder component #5966

Merged
merged 1 commit into from Jul 7, 2021
Merged

Initialize the wav encoder in the entry points instead of in the audiorecorder component #5966

merged 1 commit into from Jul 7, 2021

Conversation

marcoambrosini
Copy link
Member

fix: #5957

@marcoambrosini marcoambrosini added this to the 💖 Next Major (23) milestone Jul 7, 2021
@marcoambrosini marcoambrosini self-assigned this Jul 7, 2021
@marcoambrosini
Initialize the wav encoder in the entry points instead of in the audi…
1fb72c8 
…orecorder component

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini changed the title Bugfix/5957 Initialize the wav encoder in the entry points instead of in the audiorecorder component Jul 7, 2021
nickvergessen
nickvergessen approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xD now I see it

@marcoambrosini marcoambrosini merged commit b6ae3b8 into master Jul 7, 2021
@marcoambrosini marcoambrosini deleted the bugfix/5957 branch July 7, 2021 13:31
@nickvergessen
Copy link
Member

/backport to stable22.1

@nickvergessen
Copy link
Member

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 15, 2021
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 15, 2021
Merged
@danxuliu danxuliu mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review bug
Projects
None yet
Milestone
v13.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Error: There is already an encoder stored which handles exactly the same mime types.
2 participants
@marcoambrosini @nickvergessen