[stable20.1] Fix infinite loop when the constraints can not be decreased #6240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
The previous minimum frame rate was wrongly got from the maximum frame rate, so when the minimum frame rate was compared after decreasing it it was always seen as changed. Due to this the constraints will be applied again even if they did not actually change due to having reached the minimum capped value, which would end in an infinite loop if the constraints could not be applied and the minimum frame rate was (tried to be) decreased again. However, note that the scenario above was unlikely to happen in the real world, as the browsers would likely accept the minimum capped value for the frame rate of 1. The problem would occur if the stream did not come from a device (even virtual ones) but from an HTML canvas or something similar that does not allow to change the constraints. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The minimum value of the constraints was wrongly capped using "min" instead of "max", so in practice the first time that the value was decreased it was already set to the minimum capped value. Moreover, if the value could not be set the minimum value could be decreased in the next iteration even below the capped value. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #6101