[stable24] Fix leaving call when switching to another conversation #8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
When a conversation was left in the Files app the store was cleared to ensure that it did not contain old data if the conversation was joined again later (as the conversation data will not be updated while not in the conversation). However, as this is only needed in case the conversation is joined again this can be also done before actually joining the conversation. This change will be used to automatically leave the call when leaving the conversation; leaving the call needs to get some values from the store that were cleared, so this change avoids having to explicitly wait until the conversation was left before clearing the store. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When a conversation is joined while being in another conversation the previous conversation is left. Leaving a conversation automatically leaves the call in the server, but in the WebUI it had no effect on the call. Therefore, from the point of view of the WebUI the user was still in the call in the previous conversation, so switching back to it caused the call view to be shown again (although the call was not actually joined again, only the call view was shown). To solve that now an ongoing call is automatically left when its conversation is left. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
backportbot-nextcloud
bot
added
bug
feature: call 📹
nickvergessen
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #8519