Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Unread mentions" button occurence #8603

Merged
merged 1 commit into from Jan 27, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 25, 2023

Fix #8599

Bug appeared because of changing the scroll container with the 25 theming update.

πŸ–ΌοΈ Screenshots

Peek 2023-01-25 16-55

🚧 TODO

  • Cross-browser testing (working on Google)
  • Code review

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me πŸ‘

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but have no clue about the technical side

@nickvergessen nickvergessen merged commit 64b4d7b into master Jan 27, 2023
@nickvergessen nickvergessen deleted the fix/8599/fix-unread-mentions-button-occurence branch January 27, 2023 10:08
@Antreesy
Copy link
Contributor Author

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unread mention marker not always shown?
3 participants