Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an endpoint to return all participants #8660

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Add an endpoint to return all participants #8660

merged 4 commits into from
Feb 2, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 31, 2023 •
edited
Loading

Fix #8610

🚧 TODO

  • Add an endpoint that returns all participants of the parent room and the breakout rooms with their related status and sessions, etc.

🏁 Checklist

@nickvergessen nickvergessen added this to the 💚 Next Major (26) milestone Jan 31, 2023
@nickvergessen nickvergessen self-assigned this Jan 31, 2023
@nickvergessen nickvergessen marked this pull request as draft January 31, 2023 15:06
@nickvergessen nickvergessen force-pushed the feature/8610/add-endpoint-to-return-all-participants branch 2 times, most recently from d74afc2 to d41bd1a Compare January 31, 2023 18:53
@nickvergessen
Add an endpoint to return all participants of a room with its breakou…
6150cb4 
…t rooms

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add integration test for the "get breakout rooms participants
5af8539 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/8610/add-endpoint-to-return-all-participants branch from d41bd1a to 5af8539 Compare February 1, 2023 08:17
@nickvergessen nickvergessen marked this pull request as ready for review February 1, 2023 08:19
@nickvergessen nickvergessen mentioned this pull request Feb 1, 2023
Merged
11 tasks
marcoambrosini
marcoambrosini approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

vitormattos
vitormattos reviewed Feb 1, 2023
View reviewed changes
docs/participant.md Outdated Show resolved Hide resolved
@nickvergessen
Link to the docs section
94f8f95 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Also order attendees by roomToken for the breakout room participants
54bc20c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 820839c into master Feb 2, 2023
@nickvergessen nickvergessen deleted the feature/8610/add-endpoint-to-return-all-participants branch February 2, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@vitormattos vitormattos Awaiting requested review from vitormattos

Assignees

@nickvergessen nickvergessen

Labels
4. to release enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: breakout rooms 🖖
Projects
None yet
Milestone
v16.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Add endpoint that returns participants of all breakout-rooms for a given conversation
3 participants
@nickvergessen @vitormattos @marcoambrosini