Add specific UI for recording calls #8725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
force-pushed
the
add-specific-ui-for-recording-calls
branch
from
7434178
to
ebe6585
Compare
|
Rebase for clarification of the state? |
danxuliu
force-pushed
the
add-specific-ui-for-recording-calls
branch
from
ebe6585
to
8194631
Compare
Instead of joining the call in the main Talk page now a specific page to be used only by the recording server was added. This will make possible to use a specific UI tailored for call recording, but also to use an internal client of the external signaling server rather than a normal participant. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the call view is shown in recording mode the local participant is not shown, and there is no visible button to show the grid stripe either. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
add-specific-ui-for-recording-calls
branch
from
b93b312
to
de75def
Compare
5 tasks
nickvergessen
approved these changes
Feb 17, 2023
lib/Controller/PageController.php
Outdated
| * @param string $token | ||
| * @return TemplateResponse|NotFoundResponse | ||
| */ | ||
| public function recording(string $token = ''): Response { |
There was a problem hiding this comment.
Suggested change
| public function recording(string $token = ''): Response { | |
| public function recording(string $token): Response { |
Doesn't need to be optional, since it's part of the URL already
Signed-off-by: Joas Schilling <coding@schilljs.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8708
The recording UI can be tested without actually recording the call in the following way:
{url of the call}/recordingNote that there will be no sound, as the call is joined without any user interaction and therefore sounds are blocked. This is correctly handled when accessing the endpoint from the recording server.
🖼️ Screenshots
🚧 TODO