Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Modified since" support on roomlist #8726

Merged
merged 3 commits into from Feb 14, 2023
Merged

"Modified since" support on roomlist #8726

merged 3 commits into from Feb 14, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 9, 2023 •
edited

Fix #7299

When modifiedSince is provided only conversations with a newer lastActivity are returned.
Due to the nature of the data structure we can not return information that a conversation was deleted
or the user removed from a conversation. Therefore it is recommended to do a full refresh:

  • Every 5 minutes
  • When a signaling message of type delete or disinvite was received
  • Internal signaling mode is used

🏁 Checklist

@nickvergessen nickvergessen added this to the 💚 Next Major (26) milestone Feb 9, 2023
@nickvergessen nickvergessen self-assigned this Feb 9, 2023
@nickvergessen nickvergessen mentioned this pull request Feb 9, 2023
Closed
16 tasks
@nickvergessen nickvergessen force-pushed the perf/8710/modified-since-support-on-roomlist branch from bdf720c to a922741 Compare February 9, 2023 14:34
@nickvergessen nickvergessen removed the request for review from Ivansss February 10, 2023 08:11
@nickvergessen
Support "modified since" on the room list
a2864f2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Better handling of parameters
aeb4184 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Utilize the modifiedSince parameter of the conversations API
f112fb9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the perf/8710/modified-since-support-on-roomlist branch from a922741 to f112fb9 Compare February 10, 2023 08:23
@SystemKeeper
Copy link
Contributor

Is this basically #7299 ?

@nickvergessen
Copy link
Member Author

Yes

come-nc
come-nc approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘 Only reviewed the PHP file

@nickvergessen nickvergessen merged commit 12e24c4 into master Feb 14, 2023
@nickvergessen nickvergessen deleted the perf/8710/modified-since-support-on-roomlist branch February 14, 2023 07:52
@danxuliu danxuliu mentioned this pull request Feb 15, 2023
Open
@nickvergessen nickvergessen mentioned this pull request Feb 21, 2023
Merged
1 task
@nickvergessen nickvergessen mentioned this pull request May 23, 2023
Closed
@SystemKeeper SystemKeeper mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@vitormattos vitormattos Awaiting requested review from vitormattos

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feature: frontend 🖌️ "Web UI" client performance 🚀
Projects
None yet
Milestone
v16.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Skip old rooms from default room list and live updating?
3 participants
@nickvergessen @SystemKeeper @come-nc