Don't claim recording is enabled when no secret or servers are config… #8874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ured Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
bug
feature: api 🛠️
|
Let's see if current integration tests need adjusting |
Signed-off-by: Joas Schilling <coding@schilljs.com>
vitormattos
approved these changes
Feb 27, 2023
|
Drone passed on the first commit and after that only unit tests where adjusted. |
nickvergessen
deleted the
bugfix/noid/dont-claim-recording-works-when-not-configured
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ured
E.g. currently on c.nc.c
🏁 Checklist
docs/has been updated or is not required