Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scroll behaviour and "Scroll to bottom" button appearance #8895

Merged
merged 6 commits into from Mar 2, 2023
Merged

Fix scroll behaviour and "Scroll to bottom" button appearance #8895

merged 6 commits into from Mar 2, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 1, 2023

Fix #8856

  • Hide button by default
  • Update its appeance when scrolling (button wasn't shown when scrolling up)
  • Fixed some typos, remove redundant methods

🚧 TODO

  • Code review

🏁 Checklist

@Antreesy Antreesy added this to the 🚀 Next Beta (26) milestone Mar 1, 2023
@Antreesy Antreesy self-assigned this Mar 1, 2023
@Antreesy Antreesy enabled auto-merge March 1, 2023 11:32
@Antreesy
remove isScrolledToBottom dependency from parent and sibling
5b27a4c 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
update behaviour when initialising messages
b165816 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/8856/fix-scroll-behaviour branch from 7621365 to d71f6b5 Compare March 1, 2023 17:08
@Antreesy Antreesy disabled auto-merge March 1, 2023 17:16
ShGKme
ShGKme reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Step to reproduce:

  1. Create an empty chat
  2. Open a chat with a history
  3. Make some scroll
  4. Switch to the empty chat
  5. "Scroll to button" is expected to be invisible but it is

@Antreesy
fix imports and typos
6351ba3 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
refactor, update behaviour after focusing
9bca0db 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/8856/fix-scroll-behaviour branch from d71f6b5 to 9bca0db Compare March 2, 2023 08:37
@Antreesy Antreesy requested a review from ShGKme March 2, 2023 08:40
nickvergessen
nickvergessen approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, but I'm really scared

@Antreesy
get transition length for fade-effects from server styles
7863af1 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy enabled auto-merge March 2, 2023 10:02
@Antreesy Antreesy disabled auto-merge March 2, 2023 10:06
@Antreesy
hide button while changing between conversations
092755e 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy enabled auto-merge March 2, 2023 10:41
@Antreesy Antreesy merged commit ac623a4 into master Mar 2, 2023
17 checks passed
@Antreesy Antreesy deleted the fix/8856/fix-scroll-behaviour branch March 2, 2023 12:40
@nickvergessen nickvergessen mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client low
Projects
None yet
Milestone
v16.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Unable to scroll to the bottom of the message list
3 participants
@Antreesy @nickvergessen @ShGKme