Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not focus input on mobile #8898

Merged
merged 1 commit into from Mar 2, 2023
Merged

do not focus input on mobile #8898

merged 1 commit into from Mar 2, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Mar 1, 2023 •
edited

Follow-up to #8058

Regression of #4333

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

For my own testing 
docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
-e TALK_BRANCH=fix/noid/mobile-focus \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the 🧊 Next Patch (26) milestone Mar 1, 2023
@szaimen szaimen marked this pull request as ready for review March 1, 2023 13:30
@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2023

Tested and works. Ready for review 👍

@szaimen
do not focus input on mobile
8a3fb5c 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2023 •
edited

Rebased

@szaimen szaimen requested a review from ShGKme March 1, 2023 17:10
@nickvergessen nickvergessen merged commit 915ab9d into master Mar 2, 2023
@nickvergessen nickvergessen deleted the fix/noid/mobile-focus branch March 2, 2023 08:06
@nickvergessen nickvergessen mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review bug regression
Projects
None yet
Milestone
v16.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szaimen @nickvergessen