Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/noid/use custom component for breakoutrooms #8919

Merged

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Mar 2, 2023

Screenshot 2023-03-02 at 13 02 04

also fixes #8900

Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to go with proposed solution:

  1. if we want to add toggle logic to the rooms in the future;
  2. as rooms and participants are semantically different lists

Comment on lines +24 to +26
<Fragment>
<li :key="roomName"
class="breakout-room-item">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Fragment>
<li :key="roomName"
class="breakout-room-item">
<li :key="roomName">
<div class="breakout-room-item">

<template v-for="participant in roomParticipants">
<Participant :key="participant.actorId" :participant="participant" />
</template>
</NcAppNavigationItem>
</Fragment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</Fragment>
</div>
<ul class="breakout-room-item__participants">
<Participant v-for="participant in roomParticipants"
:key="participant.actorId"
:participant="participant" />
</ul>
</li>

@nickvergessen nickvergessen merged commit d462102 into master Mar 2, 2023
@nickvergessen nickvergessen deleted the enh/noid/use-custom-component-for-breakoutrooms branch March 2, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakout rooms icon
3 participants