New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/noid/use custom component for breakoutrooms #8919
Enh/noid/use custom component for breakoutrooms #8919
Conversation
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to go with proposed solution:
- if we want to add toggle logic to the rooms in the future;
- as rooms and participants are semantically different lists
<Fragment> | ||
<li :key="roomName" | ||
class="breakout-room-item"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Fragment> | |
<li :key="roomName" | |
class="breakout-room-item"> | |
<li :key="roomName"> | |
<div class="breakout-room-item"> |
<template v-for="participant in roomParticipants"> | ||
<Participant :key="participant.actorId" :participant="participant" /> | ||
</template> | ||
</NcAppNavigationItem> | ||
</Fragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</Fragment> | |
</div> | |
<ul class="breakout-room-item__participants"> | |
<Participant v-for="participant in roomParticipants" | |
:key="participant.actorId" | |
:participant="participant" /> | |
</ul> | |
</li> |
also fixes #8900