Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Use NcRichText component from @nextcloud/vue #8959

Merged
merged 4 commits into from Mar 6, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #8904

julien-nc and others added 4 commits March 6, 2023 10:44
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@nickvergessen
Copy link
Member

Not really a change I like to see in RC phase. is it really necessary?

@julien-nc
Copy link
Member

@nickvergessen Yes it is the proper fix for the circular dependency we had. In the current Talk's stable26 there still are style issues. All good after getting rid of @nextcloud/vue-richtext and using @nextcloud/vue only.

@nickvergessen
Copy link
Member

Yes it is the proper fix for the circular dependency we had.

I don't see any circular dependency as we are not on 7.8 yet?

In the current Talk's stable26 there still are style issues.

I don't see any open issues regarding that nor are screenshots attached to judge if they are okay to merge at the moment or urgent enough to merge during freeze

@julien-nc
Copy link
Member

I don't see any circular dependency as we are not on 7.8 yet?

Stable26 is using 7.7.2

I don't see any open issues regarding that nor are screenshots attached to judge if they are okay to merge at the moment or urgent enough to merge during freeze

Sorry, I'm currently dealing with many problems, didn't have time to create an issue. Here are some screenshots of the link/smart picker with stable26:
generic search provider
image
custom picker component
image

With this PR:
image
image

@nickvergessen
Copy link
Member

Hmm, fine by me then

@julien-nc julien-nc merged commit 9f4193e into stable26 Mar 6, 2023
@julien-nc julien-nc deleted the backport/8904/stable26 branch March 6, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants