Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakout rooms: improve semantic and a11y #8984

Merged
merged 4 commits into from Mar 7, 2023
Merged

Breakout rooms: improve semantic and a11y #8984

merged 4 commits into from Mar 7, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 7, 2023

Fix #8927

  • No visual changes
  • Fix console warnings

🚧 TODO

  • Code review
  • Visual check

🏁 Checklist

@Antreesy
change ul nesting for participants list
609c564 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
replace deprecated prop, add aria-label
cf08649 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
remove redundant wrapper
a65f9f4 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🖤 Next Major (27) milestone Mar 7, 2023
@Antreesy Antreesy self-assigned this Mar 7, 2023
@Antreesy
move a margin rule to the stable element
75c1a86 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
marcoambrosini
marcoambrosini approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@nickvergessen nickvergessen merged commit 30b8654 into master Mar 7, 2023
@nickvergessen nickvergessen deleted the fix/8927/breakoutrooms-semantic-a11y-improvements branch March 7, 2023 10:57
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 7, 2023

/backport to stable26

@nickvergessen this seems to be in stable26 too: #8921

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@Antreesy Antreesy

Labels
3. to review accessibility enhancement feature: breakout rooms 🖖 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
17.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Semantically nested lists in BreakoutRoomTab
3 participants
@Antreesy @marcoambrosini @nickvergessen