Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for desktop build #9050

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Prepare for desktop build #9050

merged 5 commits into from
Mar 21, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 13, 2023 •
edited

馃毀 TODO

  • Divide webpack.config.js into webpack.config.js and webpack.common.config.js used by desktop build
  • Add IS_DESKTOP build-time constant
  • Add globals typing (for auto-complete in IDEs) for new IS_DESKTOP as well as old build-time constants
  • Add if (IS_DESKTOP) in simple cases
    • VueRouter config
    • Page Title
    • Page reload on signaling / session issues

This is a Draft:

There are more changes

馃弫 Checklist

@ShGKme ShGKme mentioned this pull request Mar 13, 2023
Merged
10 tasks
@ShGKme
feat(desktop): prepare webpack config for desktop
13472d0 
- Define IS_DESKTOP global variable
- Separate the config to common and web parts
- Use cross-platform slashes on webpack rules' tests

Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme
feat(desktop): disable browser check on desktop
c43fb25 
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme
feat(desktop): add desktop support in the VueRouter config
02d21d0 
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme
feat(desktop): do not add Talk - to the the desktop title
c09bfbf 
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme
fix(desktop): remove page reload on session/signaling issues
deec41e 
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme ShGKme force-pushed the feat/noid/prepare-for-desktop branch from f09f2b5 to deec41e Compare March 14, 2023 09:06
@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 14, 2023 •
edited

Rebased after #9048

@ShGKme ShGKme marked this pull request as ready for review March 14, 2023 09:11
@ShGKme ShGKme mentioned this pull request Mar 16, 2023
Open
11 tasks
@nickvergessen
Copy link
Member

Merge?

@nickvergessen nickvergessen merged commit 6bd3a5e into master Mar 21, 2023
@nickvergessen nickvergessen deleted the feat/noid/prepare-for-desktop branch March 21, 2023 11:43
@nickvergessen
Copy link
Member

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@danxuliu danxuliu Awaiting requested review from danxuliu

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees
No one assigned
Labels
3. to review client: 馃馃崗 mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShGKme @nickvergessen @marcoambrosini