Fix redirect url in session error handling for desktop #9240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
ShGKme
changed the title
|
/backport to stable26 |
nickvergessen
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃拋 Description
The URL in the session error handling redirect was not correct on the Desktop.
Previously it redirected by an absolute URL. But it worked only on the dev server on the
http://protocol. An absolute path is not correct for thefile://protocol on the production build. It causes a black screen after receiving any signaling session error.The new solution updates only hash (Hash routing is used on desktop) and reloads the page.
NO CHANGES FOR WEB
鈽戯笍 Resolves
馃弫 Checklist
docs/has been updated or is not required