Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Fix missing recording settings when upload limit is INF #9244

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix(settings): Fix missing recording settings when upload limit is INF #9244

merged 1 commit into from
Apr 4, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 4, 2023 •
edited

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
grafik
grafik		 grafik

🏁 Checklist

@nickvergessen
fix(settings): Fix missing recording settings when upload limit is INF
60d42b4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants feature: recordings ⏺️ Including the recording server labels Apr 4, 2023
@nickvergessen nickvergessen added this to the 🖤 Next Major (27) milestone Apr 4, 2023
@nickvergessen nickvergessen self-assigned this Apr 4, 2023
@nickvergessen
Copy link
Member Author

/backport to stable26

@nickvergessen
Copy link
Member Author

grafik

Ivansss
Ivansss approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@nickvergessen nickvergessen merged commit 3556b04 into master Apr 4, 2023
24 checks passed
@nickvergessen nickvergessen deleted the bugfix/9181/fix-initial-state-with-INF branch April 4, 2023 11:27
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

@vitormattos vitormattos Awaiting requested review from vitormattos

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: recordings ⏺️ Including the recording server feature: settings ⚙️ Settings and config related issues
Projects
None yet
Milestone
17.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Unexpected INF value for uploadLimit results in bad JSON
2 participants
@nickvergessen @Ivansss