Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to upload custom backgrounds #9347

Merged
merged 20 commits into from May 4, 2023
Merged

Add ability to upload custom backgrounds #9347

merged 20 commits into from May 4, 2023

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Apr 21, 2023 •
edited

Commits to be squashed, best look at the whole diff.

Known issues:

☑️ Resolves

🖼️ Screenshots

Screenshot 2023-04-25 at 15 37 19

🚧 Tasks

  • ...

🏁 Checklist

@marcoambrosini marcoambrosini force-pushed the feature/9270/add-ability-to-use-custom-backgrounds branch 3 times, most recently from 3bb70d4 to 6c47342 Compare April 24, 2023 14:42
@marcoambrosini marcoambrosini self-assigned this Apr 25, 2023
@marcoambrosini marcoambrosini added this to the 💙 Next Major (27) milestone Apr 25, 2023
@marcoambrosini marcoambrosini marked this pull request as ready for review April 25, 2023 14:47
ShGKme
ShGKme previously requested changes Apr 25, 2023
View reviewed changes
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
@marcoambrosini marcoambrosini force-pushed the feature/9270/add-ability-to-use-custom-backgrounds branch from f4663af to b6c083b Compare April 27, 2023 14:30
@marcoambrosini marcoambrosini force-pushed the feature/9270/add-ability-to-use-custom-backgrounds branch from b6c083b to 132e20a Compare May 1, 2023 13:42
@marcoambrosini marcoambrosini changed the title Add ability to upload files Add ability to upload custom backgrrounds May 2, 2023
@marcoambrosini marcoambrosini changed the title Add ability to upload custom backgrrounds Add ability to upload custom backgrounds May 2, 2023
Antreesy
Antreesy reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of non-blocking suggestions

src/components/MediaSettings/MediaSettings.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
src/components/MediaSettings/VideoBackgroundEditor.vue Outdated Show resolved Hide resolved
@marcoambrosini
Add ability to use custom backgrounds
b03b4fe 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Show custom background options in grid instead of in modal
b51c588 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Show all options in main grid
4d62cb6 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Use none instead of clear for no background effect option
dad7220 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Use four columns layout
c333d55 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Center backgrounds in buttons
d0e3760 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Load previously saved backgrounds and show current selected background
3cee416 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Design improvements
8106965 
Signed-off-by: Marco <marcoambrosini@icloud.com>
marcoambrosini and others added 12 commits May 4, 2023 14:30
@marcoambrosini
Add note for translators
8da0b7c 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Use BrowserStorage instead of localstorage
27105c9 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Remove unneeded comments
6469719 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Handle exception while creating background folder
e1a5295 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Use unique id for input
a71a9a4 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Load background first
706260f 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
remove redundant Object.values
df589b0 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Display images from background folder
f780566 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Do not display background if there's no capability
36b5f43 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini @Antreesy
Update src/components/MediaSettings/MediaSettings.vue
86a8dd2 
Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Declare constants in the setup function
00f4200 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini
Update backgrounds
6f0cde9 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini marcoambrosini force-pushed the feature/9270/add-ability-to-use-custom-backgrounds branch from fb2588b to 6f0cde9 Compare May 4, 2023 12:33
@nickvergessen nickvergessen merged commit 67dee34 into master May 4, 2023
14 of 15 checks passed
@nickvergessen nickvergessen deleted the feature/9270/add-ability-to-use-custom-backgrounds branch May 4, 2023 12:44
@nickvergessen nickvergessen mentioned this pull request May 10, 2023
Merged
4 tasks
@Antreesy Antreesy mentioned this pull request Jun 15, 2023
Merged
6 tasks
@Antreesy
Copy link
Contributor

Just noticed it for the guest user (wide background images on the last row):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review enhancement
Projects
None yet
Milestone
17.0.0-beta.1
4 participants
@marcoambrosini @Antreesy @nickvergessen @ShGKme