Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix closing the left sidebar on click automatically #9508

Merged
merged 2 commits into from
May 11, 2023
Merged

fix closing the left sidebar on click automatically #9508

merged 2 commits into from
May 11, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 9, 2023

No description provided.

@szaimen szaimen added this to the 💙 Next Beta (27) milestone May 9, 2023
@nickvergessen
Copy link
Member

Shouldn't this be in the component upstream and behave the same on all usages?

@szaimen
Copy link
Contributor Author

szaimen commented May 10, 2023

Shouldn't this be in the component upstream and behave the same on all usages?

I am not sure about this as the app is currently the only one that uses the component in this way. On some other apps the behaviour will be unintended. So I would suggest doing it here...

@Antreesy Antreesy force-pushed the enh/noid/fix-sidebar-closing branch from 18e13b0 to 8755055 Compare May 10, 2023 13:23
@Antreesy Antreesy self-assigned this May 10, 2023
@Antreesy Antreesy marked this pull request as ready for review May 10, 2023 13:25
@Antreesy
Copy link
Contributor

@szaimen I pushed a fix now, please check that it works now as expected by you

@Antreesy
remove redundant emitting events
744f077 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
handle all 'joined-conversation' events
408c061 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the enh/noid/fix-sidebar-closing branch from 8755055 to 408c061 Compare May 10, 2023 14:44
@Antreesy Antreesy requested a review from ShGKme May 10, 2023 15:12
@szaimen szaimen changed the title try to fix closing the left sidebar on click automatically fix closing the left sidebar on click automatically May 10, 2023
szaimen
szaimen commented May 10, 2023
View reviewed changes
Copy link
Contributor Author

@szaimen szaimen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in my testing! Thanks a lot for fixing! (but didnt review the code)

@nickvergessen nickvergessen merged commit 1bf04bd into master May 11, 2023
19 checks passed
@nickvergessen nickvergessen deleted the enh/noid/fix-sidebar-closing branch May 11, 2023 11:34
@szaimen
Copy link
Contributor Author

szaimen commented May 11, 2023

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 11, 2023
Merged
1 task
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot May 11, 2023
@nextcloud nextcloud deleted a comment from szaimen May 11, 2023
@nickvergessen nickvergessen mentioned this pull request May 23, 2023
Closed
@Antreesy Antreesy mentioned this pull request Jun 12, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szaimen @nickvergessen @Antreesy