Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully translate aria-labels for predefined backgrounds #9710

Merged
merged 1 commit into from Jun 7, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 6, 2023

☑️ Resolves

  • Fix Aria label key words of virtual backgrounds are not translatable #9610
  • Instead of translating Select virtual {{unknown}} background' and eight single-word strings like abstract or beach, translators now need to translate eight meaningful strings (which could take up to 3-5 minutes with Transifex autocompletion)
  • Method of extracting filename without extension should work as before, according to JS prototypes behavior:
    • String.split(substr) always returns an array, even if substr isn't found;
    • Array.pop() and Array.shift() return last / first element of array, and the only existing element from 1-length array.

🖼️ Screenshots

🏡 After
image
image

🚧 Tasks

  • Code review
  • Visual check

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 6, 2023

/backport to stable27

@Antreesy Antreesy merged commit 6513cd7 into master Jun 7, 2023
19 checks passed
@Antreesy Antreesy deleted the fix/9610/translate-background-aria-labels branch June 7, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aria label key words of virtual backgrounds are not translatable
3 participants