Fix media settings in files sidebar

[marcoambrosini]

When starting a call from the files sidebar and while editing a file, the media settings was not display because it was covered by the file dialog. Increasing the z-index of the media settings dialog didn't fix the issue (it's unclear to me why not). Removing the container of the media settings dialog and thereby assigning the default body as container fixes the issue.

☑️ Resolves

• Fix Device preview prevents call from starting while editing document #8709

🖼️ Screenshots

[Antreesy]

As expected, it breaks opening media settings on fullscreen
What I'm thinking of, we could do it either:

• Make container conditional, depending on whether it's mounted, in Talk or in Files (should be enough, until we'd want to see Chat in Talk sidebar, while editing file, like it looks in Files now)
  or
• Add a portal, like @ShGKme did it for video overlay (much complicated task, but it will be future-proof, especially if we manage to do it a reusable)

[marcoambrosini]

Hmmm nice catch. Why is it that in Files the media settings are visible even in fullscreen mode while in talk they're not?

[ShGKme]

Hmmm nice catch. Why is it that in Files the media settings are visible even in fullscreen mode while in talk they're not?

As far as I know, in Files there is no real "Fullscreen mode". Only open Viewer and Fullscreen "styles" for the Sidebar.

In Talk the Fullscreen mode is a "real" fullscreen with native Fullscreen API for the Talk app (div#content-vue) element. Only Talk is "fullscreen-ed", you see no header and ect. In this mode, Talk app is a top layer element. No element outside the Talk (div#content-vue) can be above, no matter what z-index it has.

That was the reason, why Daniel created the uiMode store here: #6119

We need some huge rework here in general. I'm working on it as a part of #9626

[rriemann]

I have already notified this to our Nextcloud sales engineer. It is so important for our use to have this fixed. Please make it happen for the next update. 🙏

[Antreesy]

Just a thought: maybe we could try to replace mainContainer for the sidebars? For the main view of Talk app it's obvious to have block like #content-talk, but for Files all and others we should also cover the whole screen:

https://github.com/nextcloud/spreed/blob/master/src/mainFilesSidebar.js#L72