Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NewMessageNewFileDialog) - fix creation of file from Blank template #9812

Merged
merged 2 commits into from Jun 20, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 19, 2023

☑️ Resolves

To reproduce:

  1. in Files, click "+" => "Set Templates folder" (could be wrong with button title)
  2. Add some templates from there
  3. in Talk, click 📎 => "New text file"
  4. Try to create a file with Blank or any of the existing templates
    image
  5. Everything should work
    5.1) Or use only steps 3-4, template is Blank by default

🚧 Tasks

  • Code review

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Jun 19, 2023
@Antreesy Antreesy added this to the 💜 Next Major (28) milestone Jun 19, 2023
@Antreesy Antreesy self-assigned this Jun 19, 2023
@Antreesy
Copy link
Contributor Author

/backport to stable27

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

Though, I didn't understand what was actually changed in the mentioned commit, what caused regression...

src/components/NewMessage/NewMessageNewFileDialog.vue Outdated Show resolved Hide resolved
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Copy link
Contributor Author

Changed code based on suggestion, tested, still works

@Antreesy Antreesy enabled auto-merge June 20, 2023 07:18
@Antreesy Antreesy merged commit 11fa6f4 into master Jun 20, 2023
19 checks passed
@Antreesy Antreesy deleted the fix/9779/create-file-without-template branch June 20, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File doesn't added to conversation, when create from attachments with 'Blank' or no template
3 participants