Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call invalid function #86

Merged
merged 1 commit into from Nov 13, 2018
Merged

Do not call invalid function #86

merged 1 commit into from Nov 13, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 13, 2018

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Do not call invalid function
4c98287 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
ChristophWurst
ChristophWurst approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

MorrisJobke
MorrisJobke approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke
Copy link
Member

@rullzer Backport or not?

@rullzer
Copy link
Member Author

rullzer commented Nov 13, 2018

Yes! I'm not sure how this slipped in. I can't find this in stable9 even 😕

@rullzer rullzer added this to the Nextcloud 15 milestone Nov 13, 2018
@MorrisJobke MorrisJobke merged commit 795f171 into master Nov 13, 2018
@MorrisJobke MorrisJobke deleted the fix/proper_data_resp branch November 13, 2018 14:45
@nickvergessen
Copy link
Member

https://github.com/nextcloud/server/blob/master/lib/private/OCS/Result.php#L128

What is your probalum? https://www.youtube.com/watch?v=xrqdpaKSjCA

@nickvergessen
Copy link
Member

So only broken in 14, since
#72 where the OCS\Result was replaced with a Http Response

@MorrisJobke MorrisJobke mentioned this pull request Nov 14, 2018
Merged
24 tasks
@MorrisJobke
Copy link
Member

/backport to stable14

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable14 in #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@schiessle schiessle Awaiting requested review from schiessle

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rullzer @MorrisJobke @nickvergessen @ChristophWurst