Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #745 ValueError: random_int(): Argument #1 ($min) must be less than or equal to argument #2 ($max) #810

Merged
merged 2 commits into from
Feb 14, 2024
Merged

fix #745 ValueError: random_int(): Argument #1 ($min) must be less than or equal to argument #2 ($max) #810

merged 2 commits into from
Feb 14, 2024

Conversation

furplag
Copy link
Contributor

@furplag furplag commented Jul 6, 2023

No description provided.

ChristophWurst
ChristophWurst reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style

lib/Service/NegativeSampleGenerator.php Outdated Show resolved Hide resolved
@ChristophWurst ChristophWurst added 3. to review bug Something isn't working labels Jul 6, 2023
@furplag
Copy link
Contributor Author

furplag commented Aug 31, 2023

Should I do something ?

@AndyXheli
Copy link

Fix for #745

@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@joshtrichards joshtrichards linked an issue Feb 14, 2024 that may be closed by this pull request
ValueError: random_int(): Argument #1 ($min) must be less than or equal to argument #2 ($max) #745
Closed
@furplag @joshtrichards
fix nextcloud#745
de00469 
fallback to empty array if the array of IP addresses contains nothing
when using "random_int($min, $max)" .

Signed-off-by: furplag <furplag@furplag.jp>
@furplag @joshtrichards
fix empty array following the coding style .
4faa3de 
Signed-off-by: furplag <furplag@furplag.jp>
@ChristophWurst ChristophWurst merged commit cc59010 into nextcloud:master Feb 14, 2024
24 checks passed
@furplag furplag deleted the fix-issue-#745 branch February 14, 2024 23:44
@furplag
Copy link
Contributor Author

furplag commented Feb 14, 2024

🙇

@joshtrichards
Copy link
Member

Thanks, @furplag!

@ChristophWurst
Copy link
Member

/backport to stable28

@ChristophWurst
Copy link
Member

/backport to stable27

@backportbot backportbot bot mentioned this pull request Feb 15, 2024
Merged
@ChristophWurst
Copy link
Member

/backport to stable26

@backportbot backportbot bot mentioned this pull request Feb 15, 2024
Merged
@backportbot backportbot bot mentioned this pull request Feb 15, 2024
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
This was referenced May 3, 2024
Closed
Closed
@joshtrichards joshtrichards mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

ValueError: random_int(): Argument #1 ($min) must be less than or equal to argument #2 ($max)
5 participants
@furplag @AndyXheli @joshtrichards @ChristophWurst @blizzz