Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return type of Model::jsonSerialize() should be compatible with … #863

Merged
merged 1 commit into from Mar 25, 2024
Merged

fix: Return type of Model::jsonSerialize() should be compatible with … #863

merged 1 commit into from Mar 25, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 25, 2024 •
edited

From production:

Return type of OCA\SuspiciousLogin\Db\Model::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice at /…/apps/suspicious_login/lib/Db/Model.php#83

@nickvergessen
fix: Return type of Model::jsonSerialize() should be compatible with …
f5a427d 
…JsonSerializable::jsonSerialize(): mixed

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review labels Mar 25, 2024
@nickvergessen nickvergessen self-assigned this Mar 25, 2024
@ChristophWurst ChristophWurst merged commit fe84580 into master Mar 25, 2024
29 checks passed
@ChristophWurst ChristophWurst deleted the bugfix/noid/jsonSerialize-should-be-compatible branch March 25, 2024 09:17
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickvergessen @ChristophWurst