Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(Contexts): set active navigation entry #1037

Merged
merged 1 commit into from
May 6, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Apr 30, 2024

This is sort of a PoC actually. Addresses #933

I looked at the backend options first. The problem is that we are currently working with a set anchor, i.e. example.com/index.php/apps/tables/#/application/28, so that is no information that we have on the backend. We'd either have to change this behaviour, or to avoid completely reloading the Tables app, having a mechanism that works with both, an URL that can be understood by the server, and the inside-app URL with the anchor.

Nevertheless, I looked at the frontend bits for a quick win. And there is the quick win:

Screencast_20240430_113348.webm

It is not ideal though, because

  • the active entry is visible flicking from Tables to the Tables Application when opening the Application directly, as it is initially set by the backend, and later adjusted by the app
  • there is no exposed API to manipulated the navigation bar, so I am directly manipulating the JS class. This will easily break. It might be an approach to serve NC 29, but for 30 some API by the server would be necessary. Even if the backend scenario is solved, as laid out up front, this will be needed for inside-app Application switches.

What do you think?

@blizzz blizzz added enhancement New feature or request 3. to review Waiting for reviews labels Apr 30, 2024
@blizzz blizzz force-pushed the fix/933/active-navigation-entry branch 3 times, most recently from d3edb84 to 8901914 Compare April 30, 2024 12:35
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'd only consider that a workaround, i think this is good enough for now.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/933/active-navigation-entry branch from 8901914 to 2701178 Compare April 30, 2024 15:17
@blizzz
Copy link
Member Author

blizzz commented Apr 30, 2024

Rebased to resolve conflicts.

While I'd only consider that a workaround, i think this is good enough for now.

Definitely not more than a workaround, that's what i tried to say :)

@enjeck enjeck merged commit c0b32ce into main May 6, 2024
45 checks passed
@enjeck enjeck deleted the fix/933/active-navigation-entry branch May 6, 2024 06:47
@blizzz
Copy link
Member Author

blizzz commented May 6, 2024

@juliushaertl keep it for 0.8 or also bring it down to 0.7?

@blizzz
Copy link
Member Author

blizzz commented May 6, 2024

/backport to stable0.7

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 6, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants