-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add events for row added and row updated #1101
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: C么me Chilliet <come.chilliet@nextcloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@come-nc Why do we need these events for?
Ah, I guess related to Workflows? |
Yes! |
} | ||
|
||
public function getRow(): Row2 { | ||
return $this->row; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@come-nc To evaluate what we want to pass along in the event, could you share more insights on the use case you're covering with your workflow task? |
Usecases are multiple:
I feel like putting the whole row content information in the event is too much because it may be a lot of data, while putting only the id allows to fetch the data from the API if needed. Not entirely sure. Maybe content but capped at a given maximum length would make sense? The event will need to be serialized by implementing upcomming |
No description provided.