Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(View): 'manageTable' array key is not always set #1136

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix(View): 'manageTable' array key is not always set #1136

merged 2 commits into from
Jun 11, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jun 11, 2024

fixes #1131

  • the actual fix is in the first commit, c90568d
  • the second one has style and minor adjustments only, just housekeeping

@blizzz
fix(View): 'manageTable' array key is not always set
c90568d 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
style(PHP): fix style, missing virtual methods, missing static keywords
9564f3c 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added bug Something isn't working 3. to review Waiting for reviews labels Jun 11, 2024
@juliushaertl juliushaertl merged commit 75d5ddf into main Jun 11, 2024
58 checks passed
@juliushaertl juliushaertl deleted the fix/1131/undefined-manageTable branch June 11, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@elzody elzody Awaiting requested review from elzody

@enjeck enjeck Awaiting requested review from enjeck

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined array key "manageTable" at ViewService.php#419
3 participants
@blizzz @nickvergessen @juliushaertl