Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide Create Column button on empty table if inadequate permissions #1151

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: hide Create Column button on empty table if inadequate permissions #1151

merged 1 commit into from
Jun 17, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Jun 17, 2024

Fixes #1150

@enjeck
fix: hide Create Column button if no permissions
6a944ec 
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck enjeck self-assigned this Jun 17, 2024
@enjeck enjeck added the 3. to review Waiting for reviews label Jun 17, 2024
@enjeck enjeck added the bug Something isn't working label Jun 17, 2024
elzody
elzody approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, looks good.

@blizzz blizzz merged commit fd8e75b into main Jun 17, 2024
45 checks passed
@blizzz blizzz deleted the hide-btn branch June 17, 2024 20:56
@blizzz
Copy link
Member

blizzz commented Jun 17, 2024

/backport to stable0.7

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jun 17, 2024
@backportbot backportbot bot mentioned this pull request Jun 17, 2024
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody elzody approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@enjeck enjeck

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Create Column" button shows on shared table without adequate permissions
3 participants
@enjeck @blizzz @elzody