fix: Remove deleted resource from associated applications #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 I thought we/I did it in the past 😕 |
juliushaertl
requested changes
Jun 26, 2024
Comment on lines
+258
to
+267
| foreach ($nodeRelIds as $nodeRelId) { | ||
| $this->pageContentMapper->deleteByNodeRelId($nodeRelId); | ||
| $this->contextNodeRelMapper->deleteByNodeRelId($nodeRelId); | ||
| } |
There was a problem hiding this comment.
We can save the n+1 queries here by rather having methods that support multiple ids in an array and use an IN() sql statement. Might not be crucial here but generally a good pattern to follow for performance instead of doing queries in a loop
There was a problem hiding this comment.
Not sure how to go about this 😕 😕
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1027