Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scheme import and export #1170

Merged
merged 4 commits into from
Jul 25, 2024
Merged

add scheme import and export #1170

merged 4 commits into from
Jul 25, 2024

Conversation

grnd-alt
Copy link
Member

resolves #1122

@grnd-alt grnd-alt force-pushed the feat/template-schema-export branch from 58885db to 456d9c4 Compare July 11, 2024 10:27
@grnd-alt grnd-alt force-pushed the feat/template-schema-export branch 3 times, most recently from 2a93830 to 082c986 Compare July 22, 2024 10:37
@grnd-alt grnd-alt force-pushed the feat/template-schema-export branch from 082c986 to 1f9084e Compare July 22, 2024 13:56
@juliushaertl juliushaertl requested review from blizzz and removed request for max-nextcloud July 23, 2024 08:48
@juliushaertl
Copy link
Member

Just noticed that we have one part of the requirement list from the issue missing, but I'd say we can get this in as a first step and then follow up with an additional pull request:

Exporting an application likely should include the schema of all linked tables/views

@juliushaertl juliushaertl added enhancement New feature or request 2. developing Work in progress labels Jul 23, 2024
@grnd-alt
add scheme import and export
36a43e0 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt
add views to table scheme
939867b 
add version to table scheme

move getScheme to tableService

Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt
add non ocs getscheme endpoint
dac1643 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt force-pushed the feat/template-schema-export branch from 97a154f to 5caec0e Compare July 24, 2024 11:21
@grnd-alt
add fake form to download tables export
9255651 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt force-pushed the feat/template-schema-export branch from 5caec0e to 9255651 Compare July 24, 2024 11:36
juliushaertl
juliushaertl approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but file follow up tickets for:

  • Schema import/export of applications in tables
  • Integration tests for the API endpoints

@grnd-alt grnd-alt merged commit 8944979 into main Jul 25, 2024
59 checks passed
@grnd-alt grnd-alt deleted the feat/template-schema-export branch July 25, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@elzody elzody Awaiting requested review from elzody

@enjeck enjeck Awaiting requested review from enjeck

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template/schema export/import
2 participants
@grnd-alt @juliushaertl