Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set composer platform version to PHP 7.4 as it's the minimum compatible version for NC25 #298

Merged
merged 6 commits into from May 21, 2023

Conversation

tcitworld
Copy link
Member

Some other dependencies might get updated in the process, but no big changes

Closes #295

… minimum compatible version for NC25

Some other dependencies might get updated in the process, but no big changes

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added 3. to review Waiting for reviews regression Regression of a previous working feature labels May 16, 2023
@juliushaertl
Copy link
Member

@datenangebot Might be good to also extend the test matrix to run integration tests against the minimum server+php version https://github.com/nextcloud/tables/blob/main/.github/workflows/integration.yml#L29-L31

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@datenangebot datenangebot self-assigned this May 17, 2023
@datenangebot
Copy link
Collaborator

Might be good to also extend the test matrix to run integration tests against the minimum server+php version https://github.com/nextcloud/tables/blob/main/.github/workflows/integration.yml#L29-L31

@juliushaertl Is it possible to configure php-versions in combination with server-versions? Or do we need separate workflow-files for it?

Florian Steffens added 2 commits May 17, 2023 11:41
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@tcitworld
Copy link
Member Author

You can also now add stable27, the branch was just created.

Florian Steffens added 2 commits May 17, 2023 18:45
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@datenangebot datenangebot merged commit ca1e108 into main May 21, 2023
49 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bring-back-7.4-compat branch May 21, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables 0.5.0 incompatible with PHP 7.4
3 participants