Feat(Views): Manage data presentation of tables by views #426

Hephi2 · 2023-07-21T08:49:40Z

Views are tables that contain and display certain data of the underlying data table. Views allow you to select the columns to display and their order, filter and sort the rows. Combined with functions such as sharing with specific permissions and more, this enables the creation of workflows.

View related

Unrelated but still solved

Resolves Incorrect order of the table columns after reordering #343
Resolves Column filters are case-sensitive #424
Resolves Provide better Column Sorting incl. Interface #230 ?
Resolves Move column order in "edit columns" is fuzzy #108

juliushaertl

Some early comments on the first batch of files I went over. Overall this looks super nice already :)

appinfo/info.xml

juliushaertl · 2023-07-21T15:15:58Z

appinfo/routes.php

 		['name' => 'api1#getColumn',	'url' => '/api/1/columns/{columnId}', 'verb' => 'GET'],
 		['name' => 'api1#deleteColumn',	'url' => '/api/1/columns/{columnId}', 'verb' => 'DELETE'],
 		['name' => 'api1#updateColumn',	'url' => '/api/1/columns/{columnId}', 'verb' => 'PUT'],
 		// -> rows -> table
 		['name' => 'api1#indexTableRowsSimple',	'url' => '/api/1/tables/{tableId}/rows/simple', 'verb' => 'GET'],
-		['name' => 'api1#indexTableRows',	'url' => '/api/1/tables/{tableId}/rows', 'verb' => 'GET'],


Not sure if we may need to keep a compatibility endpoint (for this and other dropped ones) to just point to the base view then, as I know @stefan-niedermann is already using this API for an Android client in the works ;)

@juliushaertl if you can give me a list of dropped endpoints I can tell you which one are problematic for the Tables Android App 🙂

APIs used by the Tables Android App 1.1.2:

GET /tables POST /tables DELETE /tables/{tableId} PUT /tables/{tableId} GET /tables/{tableId}/columns POST /tables/{tableId}/columns PUT /columns/{columnId} DELETE /columns/{columnId} GET /tables/{tableId}/rows <-- Dropped? POST /tables/{tableId}/rows PUT /rows/{rowId} DELETE /rows/{rowId}

If one of them needs to get dropped, it would be awesome to maintain backward compatibility for at least one major version of the Tables server app while announcing deprecations for the APIs that shall be dropped, so 3rd party users have some time to adapt the changes.

Looking forward to a list of APIs that will be dropped and which replacements will be there 🙂

@juliushaertl / @datenangebot ping 🙂

Given the PR has been merged, I assume that there are breaking changes in the API? Are the differences documented or announced somewhere?

@juliushaertl @datenangebot

Hi, all routes are back and should work as before, no breaking changes.
(Some new routes are not yet documented: #452)

juliushaertl · 2023-07-21T15:22:48Z

lib/Controller/Api1Controller.php

+		if ($keyword) {
+			return $this->handleError(function () use ($keyword, $limit, $offset) {
+				return $this->viewService->search($keyword, $limit, $offset);
+			});
+		} else {
+			return $this->handleError(function () use ($tableId) {
+				return $this->viewService->findAll($this->tableService->find($tableId));
+			});
+		}
+


Might be personal preference but I feel something like this would be easier to read and saves the extra else branch:

Suggested change

if ($keyword) {

return $this->handleError(function () use ($keyword, $limit, $offset) {

return $this->viewService->search($keyword, $limit, $offset);

});

} else {

return $this->handleError(function () use ($tableId) {

return $this->viewService->findAll($this->tableService->find($tableId));

});

}

return $this->handleError(function () use ($keyword, $limit, $offset) use (keyword, $limit, $offset) {

if ($keyword !== null) {

return $this->viewService->search($keyword, $limit, $offset);

}

return $this->viewService->findAll($this->tableService->find($tableId));

});

Null check would also be safer to do a strict comparison as it allows to use the limit/offset with an empty search term. In gerneral findAll and search could probably be combined in one method.

Actually looking at it again, i find it odd that search ignores the tableId

lib/Controller/ColumnController.php

lib/Db/ColumnTypes/DatetimeColumnQB.php

lib/Migration/Version000603Date20230703000000.php

juliushaertl · 2023-07-21T15:42:05Z

lib/Migration/Version000603Date20230703000000.php

+			$table->addColumn('filter', \Doctrine\DBAL\Types\Types::JSON, [
+				'notnull' => false,
+			]);
+			$table->setPrimaryKey(['id']);


We should carefully review the queries at some point and see where it would make sense to add indices to the tables

lib/Reference/ReferenceHelper.php

github-actions · 2023-08-05T02:16:07Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

kesselb · 2023-08-08T13:46:15Z

Great job, thank you 👍

kesselb · 2023-08-08T13:51:50Z

lib/Db/ColumnTypes/IColumnTypeQB.php

+interface IColumnTypeQB {
+	public const DB_PLATFORM_MYSQL = 0;
+	public const DB_PLATFORM_PGSQL = 1;
+	public const DB_PLATFORM_SQLITE = 2;


Please add another constant for Oracle DB, usually called oci in our code.

Currently, because MySQL is the else in formatCellValue, it would use the MySQL dialect, which is not going to work 😞

Oracle is not yet supported. No plans for it yet.
Install shouln't be possible on oci db backends...

Lucky you 😃