-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to vite for bundling #830
base: chore/bump-libraries
Are you sure you want to change the base?
Conversation
@juliushaertl You say "based on #647", but I don't see how? |
Doesn't work for me after running |
Sorry, it isn't ready yet, didn't wanted to ask for review but the ones got autoassigned by github 🙈 I'll ping you once I'm ready :) |
361c96e
to
41969f4
Compare
00d24b2
to
f775f18
Compare
a4bb4c9
to
44acae1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for looking into this.
I have some minor comments only.
Locally I get a warming when building:
I think the ?? ''
can just be removed in this case - but it would also be nice to catch such warnings in the ci or so. However i was not able to trigger that check on its own.
I also noticed that tables have dark favicons for me now:
I don't know if that's related. Will try and build with main branch to compare.
Just tried with current main with the same result. So not related to this PR. |
Likely caused by #712 then |
We need to decide when to merge this, currently the vite build requires nextcloud/server#36057 which is 27 only. |
@susnux I'm having some trouble here with the |
Should be fixed now: vitejs/vite#15951 |
The warning means that the right part is never null / undefined because
So just brackets are missing like (Otherwise you might get |
@susnux The two issues i mentioned in person now on this PR after updating
diff --git a/lib/composables/isPublic.ts b/lib/composables/isPublic.ts
index ec89e8b..a1000ca 100644
--- a/lib/composables/isPublic.ts
+++ b/lib/composables/isPublic.ts
@@ -10,7 +10,7 @@ import { onBeforeMount, ref } from "vue"
export const useIsPublic = () => {
const checkIsPublic = () => (document.getElementById('isPublic') as HTMLInputElement|null)?.value === '1'
- const isPublic = ref(true)
+ const isPublic = ref(checkIsPublic())
onBeforeMount(() => { isPublic.value = checkIsPublic() })
return { |
823e7f5
to
6729bf7
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net> fix: Imports Signed-off-by: Julius Härtl <jus@bitgrid.net> chore: Move to new file picker api for esm compatibility Signed-off-by: Julius Härtl <jus@bitgrid.net> fix: Make CI pass Signed-off-by: Julius Härtl <jus@bitgrid.net> fix: Update file picker usage Signed-off-by: Julius Härtl <jus@bitgrid.net> ci: Fix cypress Signed-off-by: Julius Härtl <jus@bitgrid.net> fix file picker Signed-off-by: Julius Härtl <jus@bitgrid.net> fix cypress Signed-off-by: Julius Härtl <jus@bitgrid.net> fix: Proper css for all entrypoints Signed-off-by: Julius Härtl <jus@bitgrid.net> fix: Properly load styles Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@nextcloud/vue
@nextcloud/dialogs
and@nextcloud/files