feat: autodetect data type during import #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luka-nextcloud
added
enhancement
|
Tested and works. @luka-nextcloud Do you see any possibility to also detect other formats from the phpspreadsheet? Especially around number decimals, currency, boolean values, maybe even data validity? Another possible example test case file Formats empty.ods. Btw. would also be fine to merge this already and proceed with follow up PRs. |
luka-nextcloud
force-pushed
the
feature/detect-data-type-during-import
branch
from
816fef4
to
a93b81b
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com> feat: autodetect data type during import
juliushaertl
force-pushed
the
feature/detect-data-type-during-import
branch
from
a93b81b
to
262d093
Compare
juliushaertl
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autodetect data type during import.