feat(Context): add share logic for contexts #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
feat/noid/context-sharing
branch
3 times, most recently
from
1f517e0
to
7cb65d8
Compare
blizzz
added
3. to review
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
enjeck
reviewed
Apr 15, 2024
blizzz
force-pushed
the
feat/noid/context-sharing
branch
from
96a45f0
to
54cc20c
Compare
enjeck
force-pushed
the
feat/noid/context-sharing
branch
from
54cc20c
to
d164cb2
Compare
juliushaertl
approved these changes
Apr 23, 2024
| * @psalm-param ("default"|"self") $target | ||
| */ | ||
| public function updateShareDisplayMode(int $shareId, int $displayMode, string $target = 'default'): DataResponse { | ||
| if ($target === 'default') { |
There was a problem hiding this comment.
Could become a constant, same as self
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
…ient Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- that is through the internal endpoints /tables/table and /tables/view Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
juliushaertl
force-pushed
the
feat/noid/context-sharing
branch
from
9567a5c
to
a69fe15
Compare
blizzz
added
4. to release
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
juliushaertl
force-pushed
the
feat/noid/context-sharing
branch
from
a69fe15
to
9598e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #311 and #897
createShareendpoints where extended with the optional parameterdisplayMode, which is only effective for contexts. The permissions flags on the other hand are not effective for contexts at the moment.updateShareDisplayMode(Routes:api1#updateShareDisplayModeandshare#updateDisplayMode) endpoint was added, as the only updatable endpoint was against purely against permissions.