Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not usable offline and slow on bad connection #217

Open
jancborchardt opened this issue Jun 27, 2018 · 21 comments
Open

Not usable offline and slow on bad connection #217

jancborchardt opened this issue Jun 27, 2018 · 21 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request medium Medium priority

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Jun 27, 2018

The list of calls and contacts seems to load from the server every time the app is opened. This results in a second at least of unresponsiveness and more on usual mobile connections.

When offline (or in a tunnel or plane) you are not able to view any conversations or messages.

We should cache the

  • conversations,
  • contacts and
  • messages

so loading is instant. Updates from the server can still be fed in when they come.

@mario, and same for iOS app @Ivansss

@jancborchardt jancborchardt added the enhancement New feature or request label Jun 27, 2018
@mario mario added this to the v4.0 milestone Dec 7, 2018
@mario mario modified the milestones: vX.Y+1, v8.0.0 Oct 18, 2019
@mario mario modified the milestones: v8.0.0, v9.0.0 Jan 10, 2020
@mario mario closed this as completed Apr 5, 2020
@szaimen

This comment has been minimized.

@kai11
Copy link

kai11 commented Jul 2, 2021

Why this is closed? This is not working.
v11.1.2 don't show anything (blank list of conversations) when phone in airplane mode.

@szaimen
Copy link

szaimen commented Jul 2, 2021

Yes, this was only fixed in a different branch. -> reopening

@szaimen szaimen reopened this Jul 2, 2021
@szaimen
Copy link

szaimen commented Jul 2, 2021

cc @mahibi @AndyScherzinger

@mahibi
Copy link
Collaborator

mahibi commented Jul 2, 2021

thanks for reopening @szaimen !
Indeed that's a very important issue that needs to be solved!

@MRFU510N88
Copy link

Is this something that is going to be implemented as its been quiet in here since 2018 with no real update as far as I can see?

@AndyScherzinger
Copy link
Member

We plan to have this yes, while we don't have a fixed date/release so no ETA. The age of an issue has no implication about a feature being implemented at some point or not.

@MRFU510N88
Copy link

I appreciate that,

The purpose of my previous comment was to shed some light on whether there were any plans to implement this as there was no definitive responses to support any development having taken place.

I'm sure most will agree this request is a primary feature of any messaging platform and NC Talk would benefit from the ability.

Thank you for your consideration.

@AndyScherzinger AndyScherzinger added the 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) label Jul 8, 2021
@AndyScherzinger
Copy link
Member

The purpose of my previous comment was to shed some light on whether there were any plans to implement this as there was no definitive responses to support any development having taken place.

Thanks for the hint, I labelled it accordingly now 👍

I'm sure most will agree this request is a primary feature of any messaging platform and NC Talk would benefit from the ability.

Absolutely while it is hard to say when it is getting implemented since there are usually other features one might also consider primary features :)

@mokazemi
Copy link

mokazemi commented May 9, 2022

I've read in Nextcloud Talk V9.0 change log that it has offline support.

But I see something like this when I open the Android app without internet connection. Is this something related to discussed issue?

image

@dinesh-dot-com
Copy link

Hi, every one i have a plan to make the content visible even on offline. But i can't able to edit that file. it show that it was read only file. I'm using android studio it not allowing me to edit such file. some buddy help me to make it as writeable file.

At classes.jar/coil/network/NetworkObservance.kt we can able to make the application to viewable on offline but confusing the condition statement. so help me friends.

@AndyScherzinger
Copy link
Member

Hi @DineshRefex thanks for taking an interest in this matter, this is highly appreciated. To comment on your approach, I believe it is not the right way to change a 3rd party library in use (in this case coil) but rather to find a way to cache the files to disc in case they had been loaded before.

Cc @mahibi @timkrueger in case you are aware of any caching on place already when loading files through coil (or any other approach in place)

@dinesh-dot-com
Copy link

Thanks for the reply bro @AndyScherzinger , what is the possibility for offline mode.

@AndyScherzinger
Copy link
Member

Would need to look into what coil can do, or you might be able to look into coil and if it offers some caching capabilities. I am currently afk for the week.

@timkrueger
Copy link
Contributor

Hello @DineshRefex .Thank you very much for your interest to implement offline support.

Offline support is a major architectural and behavioral change to the app. There's so many things that can go wrong design-wise and functionality-wise. For that an experienced Android developer with a good understanding of Talk is needed. Unfortunately, this is not suited for first time contributors, and is something we want to tackle ourselves.

If you're interested beside this issue to contribute to NC Talk for Android, your help is very welcome. And we're happy to help starting. Good issues to start a labeled with good first issue.

@dinesh-dot-com
Copy link

dinesh-dot-com commented Aug 31, 2022 via email

@dinesh-dot-com
Copy link

dinesh-dot-com commented Aug 31, 2022 via email

@dinesh-dot-com
Copy link

dinesh-dot-com commented Sep 1, 2022 via email

@nickvergessen nickvergessen added the medium Medium priority label Dec 22, 2022
@louim-lbs
Copy link

I would like to say that this is the only important missing feature that prevents my collaborators from adopting the application.

Waiting 2-3 seconds when loading the application to see the list of conversations + 2-3 seconds when opening the conversation to see a message, it's definitely too slow...

Other than that, everything else is great!

@rriemann
Copy link

Dear all,

when staff members install Nextcloud Talk on private devices, chats and files belonging to the organisation become difficult to control and to keep secure. So having no caching is in that moment a security advantage. Please consider this when implementing caching. At best, the nextcloud server could impose a policy on caching that mobile clients respect.

@louim-lbs
Copy link

This security "feature" is indeed interesting, I didn't think about it.

This could be an option configurable by the admin, maybe for each user and/or each conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request medium Medium priority
Projects
Status: 🏗️ In progress
Status: 🧭 Planning evaluation / ideas
Development

No branches or pull requests