Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to open conversation list when navigating back #2960

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Apr 21, 2023

Fix to open conversation list when navigating back after chat was opened by notification

fix #2959 which was when working on #1551

created #2961 to migrate away from onBackPressed

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

…ned by notification

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi self-assigned this Apr 21, 2023
@mahibi mahibi added the 3. to review Waiting for reviews label Apr 21, 2023
@mahibi mahibi added this to the 16.1.0 milestone Apr 21, 2023
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings109109
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code163163
Internationalization55
Malicious code vulnerability33
Performance1111
Security22
Total193193

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2960-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi
Copy link
Collaborator Author

mahibi commented Apr 21, 2023

If somehow this solution turns out to be problematic, another approach can be to use the TaskStackBuilder:

https://developer.android.com/reference/androidx/core/app/TaskStackBuilder

https://stackoverflow.com/questions/36912325/why-do-we-use-the-taskstackbuilder

@mahibi mahibi merged commit 0e1511a into master Apr 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/2959/fixToOpenConvList branch April 21, 2023 11:54
@AndyScherzinger AndyScherzinger modified the milestones: 16.1.0, 17.0.0 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after chat was opened by notification: fail to go back to conversation list
2 participants