Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/3070/list open conversations #3102

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Feature/3070/list open conversations #3102

merged 1 commit into from
Jun 19, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Jun 15, 2023 •
edited
Loading

resolve #3070

🖼️ Screenshots

option in contacts view listed open conversations no open conversations
grafik grafik grafik

🚧 TODO

followup: load avatars from server when nextcloud/spreed#9600 is solved

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi
Copy link
Collaborator Author

mahibi commented Jun 15, 2023

from my POV this PR should serve as example to replace the eu.davidea.flexibleadapter lib in other activities...

@mahibi mahibi force-pushed the feature/3070/listOpenConversations branch from 6c85796 to e0b5b67 Compare June 16, 2023 07:36
@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Jun 16, 2023
@mahibi mahibi force-pushed the feature/3070/listOpenConversations branch 2 times, most recently from 635b18f to 1bd667f Compare June 16, 2023 08:56
@mahibi mahibi added this to the 17.1.0 milestone Jun 16, 2023
@mahibi mahibi added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 16, 2023
@mahibi mahibi self-assigned this Jun 16, 2023
@mahibi mahibi mentioned this pull request Jun 16, 2023
Closed
3 tasks
@mahibi mahibi enabled auto-merge (rebase) June 16, 2023 14:07
@AndyScherzinger

This comment was marked as resolved.

Sign in to view
@mahibi
add option to list open conversations
fa36181 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the feature/3070/listOpenConversations branch from 1bd667f to fa36181 Compare June 19, 2023 16:35
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3102-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

AndyScherzinger
AndyScherzinger approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mahibi - looks good to me 👍

@mahibi mahibi merged commit fdde5d2 into master Jun 19, 2023
13 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/3070/listOpenConversations branch June 19, 2023 21:42
@mahibi mahibi mentioned this pull request Jun 20, 2023
Open
@DorraJaouad DorraJaouad mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
17.1.0
Development

Successfully merging this pull request may close these issues.

Make list of open conversations discoverable and usable
2 participants
@mahibi @AndyScherzinger